Fixes for things found with the NSS regression suite #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinuxJedi
force-pushed
the
nss-fixes
branch
4 times, most recently
from
4c38cd8 to
94ad8ff
Compare
Contributor
|
@julek-wolfssl when back could you review this? Please un-assign yourself and assign to wolfssl-bot when ready for final review/merge. |
julek-wolfssl
requested changes
Jul 7, 2025
LinuxJedi
force-pushed
the
nss-fixes
branch
2 times, most recently
from
6a48d28 to
c929ebf
Compare
julek-wolfssl
previously requested changes
Jul 10, 2025
Merged
julek-wolfssl
force-pushed
the
nss-fixes
branch
2 times, most recently
from
bb1c7dd to
6e43521
Compare
LinuxJedi
force-pushed
the
nss-fixes
branch
4 times, most recently
from
857da01 to
1fcfe68
Compare
* Declare `CKM_HKDF_KEY_GEN` properly * Increase object cuonts for NSS * Add configdir parameter during `C_Initialize` for NSS
`C_CopyObject` was not doing a proper copy. This changes the behaviour so that it does.
Length calculation was incorrect, causing an error. In addition, lengths for arrays were double-stored.
LinuxJedi
force-pushed
the
nss-fixes
branch
3 times, most recently
from
cf9ac1e to
815123c
Compare
dgarske
approved these changes
Aug 5, 2025
Collaborator
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
Let's get this PR merged. Reviewed and tested
Collaborator
|
Note: There is an occasional issue with TPM based ECC verify I am trying to locate. Only happens on the ARM cross compiled tests. |
mattia-moffa
approved these changes
Aug 5, 2025
julek-wolfssl
approved these changes
Aug 6, 2025
douzzer
approved these changes
Aug 6, 2025
Contributor
douzzer
left a comment
douzzer
left a comment
There was a problem hiding this comment.
left a note to revisit the XMEMSET() of sensitive data -- change to ForceZero() in a follow-up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CKM_HKDF_KEY_GENproperlyC_Initializefor NSSC_CopyObjectwas not doing a proper copy. This changes the behaviour so that it does.C_CopyObjecttemplate check if there is aulCountWP_EC_Derivewould crash when the point isn't DER encodedCKM_RSA_PKCSto wrap and unwrapC_Decryptshould returnCKR_ENCRYPTED_DATA_INVALIDwhen decryptionfails
CKO_DATAobjects